Skip to content

Update the MCP issue template to clarify the process #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2025

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Jul 8, 2025

cf. Forge side: rust-lang/rust-forge#912.

Compared to the current version, this PR modifies:

A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.

  • Compiler team contributors is not a thing now.
  • MCPs can be approved both by second or by full team FCP, so include both "equally" here immediately.
  • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.

Delegate to Forge docs https://forge.rust-lang.org/compiler/proposals-and-stabilization.html instead of trying to reproduce a less complete subset here.

  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

The mechanism around concerns (and restarting FCP countdown) wasn't explicit/clear, so explicitly spell out the flow.

r? @apiraino (or compiler)

@rustbot

This comment was marked as off-topic.

@apiraino
Copy link
Contributor

apiraino commented Jul 9, 2025

All's good here for me, thanks.

Leaving it open to someone else to give it another read

@apiraino apiraino merged commit 8b92522 into rust-lang:master Jul 10, 2025
@jieyouxu jieyouxu deleted the adjust-mcp-message branch July 10, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants